Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: bc8434a The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThis PR migrates the icon set across the Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| export { default as ApplePay } from './apple-pay.svg'; | ||
| export { default as ArrowLeftIcon } from './arrow-left.svg'; | ||
| export { default as ArrowRightButtonIcon } from './arrow-right-button.svg'; | ||
| export { default as ArrowRightButtonIcon } from './triangle-right.svg'; |
There was a problem hiding this comment.
could we add exports for the new names so that it's easier to correlate them between the SDK and Figma? For example, I assume Figma will list the icon as triangle-right, so we'd be expecting to use the TriangleRight icon. I think keeping the older name is fine for now (we'll want to clean them up later though).
There was a problem hiding this comment.
yeah thats a good callout 👍🏼 will get that update.
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/dev-cli
@clerk/expo
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/hono
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
Description
Migrate to new icon set https://www.figma.com/design/bTar3y0gIglvIxhmZsfHsj/Clerk-Mosaic?node-id=71-567&p=f&m=dev
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change